Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

side quest follow unkey x account #2352

Closed
wants to merge 1 commit into from
Closed

side quest follow unkey x account #2352

wants to merge 1 commit into from

Conversation

Harsh9485
Copy link

@Harsh9485 Harsh9485 commented Oct 12, 2024 •
edited by coderabbitai bot
Loading

What does this PR do?

I follow unkey on X.

Fixes # (issue)

If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing Guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand areas
  • Ran pnpm build
  • Ran pnpm fmt
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Unkey Docs if changes were necessary

Summary by CodeRabbit

  • New Features
    • Added a new participant entry for the Unkey X account, enhancing the list of side quest participants.
    • Updated document with details of the new participant, including name and account link.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2024

⚠️ No Changeset found

Latest commit: 84c2f2d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 12, 2024 •
edited
Loading

📝 Walkthrough

Walkthrough

The pull request updates the document oss.gg/3_follow_the_unkey_x_account.md to include a new entry for a participant who followed the Unkey X account. This addition records the date, participant name, and a link to their account, thereby expanding the list of participants in the related side quest.

Changes

File Change Summary
oss.gg/3_follow_the_unkey_x_account.md Added entry for participant Harsh Panwar who followed the Unkey X account on 12-October-2024.

Possibly related PRs

Suggested labels

🕹️ oss.gg, :joystick: 50 points

Suggested reviewers

  • mcstepp
  • chronark
  • perkinsjr
  • MichaelUnkey

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 12, 2024 •
edited
Loading

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Here is an example:

<type>[optional scope]: <description>
fix: I fixed something for Unkey

Details:

No release type found in pull request title "side quest follow unkey x account". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

coderabbitai[bot]
coderabbitai bot reviewed Oct 12, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
oss.gg/3_follow_the_unkey_x_account.md (1)

44-46: Enclose the URL in angle brackets for consistency.

The new entry looks good, but let's make a small adjustment for consistency with other entries and to follow Markdown best practices:

Please apply the following change:

 » 12-October-2024 by [Harsh Panwar](@Harsh9485)
-» Link to Account: https://x.com/harsh_panw24270
+» Link to Account: <https://x.com/harsh_panw24270>

This change will:

  1. Make the entry consistent with some of the previous entries (e.g., Chirag Arora's entry).
  2. Address the Markdownlint warning about bare URLs (MD034).
  3. Improve the Markdown formatting for better rendering and accessibility.
🧰 Tools
🪛 Markdownlint

45-45: null
Bare URL used

(MD034, no-bare-urls)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 3c04102 and 84c2f2d.

📒 Files selected for processing (1)
  • oss.gg/3_follow_the_unkey_x_account.md (1 hunks)
🧰 Additional context used
🪛 Markdownlint
oss.gg/3_follow_the_unkey_x_account.md

45-45: null
Bare URL used

(MD034, no-bare-urls)

🔇 Additional comments (1)
oss.gg/3_follow_the_unkey_x_account.md (1)

44-46: LGTM! The new entry is correctly placed and formatted.

The new entry for Harsh Panwar is correctly added at the end of the list, maintaining the chronological order. The content follows the specified schema and provides all the required information.

Once the URL formatting is adjusted as suggested in the previous comment, this change will be perfect and ready to merge.

🧰 Tools
🪛 Markdownlint

45-45: null
Bare URL used

(MD034, no-bare-urls)

@chronark
Copy link
Collaborator

please sign the CLA

@chronark chronark self-assigned this Oct 13, 2024
@MichaelUnkey
Copy link
Collaborator

/award 50

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 15, 2024

Awarding Harsh9485: 50 points 🕹️ Well done! Check out your new contribution on oss.gg/Harsh9485

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@perkinsjr perkinsjr Awaiting requested review from perkinsjr perkinsjr is a code owner

@chronark chronark Awaiting requested review from chronark chronark is a code owner

@mcstepp mcstepp Awaiting requested review from mcstepp mcstepp is a code owner

@MichaelUnkey MichaelUnkey Awaiting requested review from MichaelUnkey MichaelUnkey is a code owner

Assignees

@chronark chronark

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Harsh9485 @CLAassistant @chronark @MichaelUnkey